feat: enforce configurable minimum password length when strict#452
Closed
VaibhavAcharya wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
VaibhavAcharya
force-pushed
the
vaibhavacharya/ex-1871-identity-no-password-complexity-requirements-gotrue-brk-chng
branch
from
18330fe to
8fcf71e
Compare
VaibhavAcharya
force-pushed
the
vaibhavacharya/identity-security-opt-in
branch
from
c20c091 to
d16a894
Compare
VaibhavAcharya
force-pushed
the
vaibhavacharya/ex-1871-identity-no-password-complexity-requirements-gotrue-brk-chng
branch
from
8fcf71e to
aea5274
Compare
VaibhavAcharya
deleted the
vaibhavacharya/ex-1871-identity-no-password-complexity-requirements-gotrue-brk-chng
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Summary
Part of splitting the Identity security hardening work into reviewable pieces. Stacked on the opt-in flag wiring (#451); depends on its
Security.Strictflag.GoTrue enforces no minimum password length, so an instance accepts trivially short passwords. This adds a minimum-length check gated on
Security.Strict: with the flag off, behavior is unchanged. The minimum isSecurity.MinPasswordLength, defaulting to 8 when strict is on and the value is unset. Length is counted in runes, not bytes, so a handful of multi-byte glyphs can't satisfy a policy meant to enforce real length, and the existing 72-byte bcrypt cap still takes precedence.- Test plan
go build ./...andgo vet ./...pass.go test -run 'TestValidatePassword|TestSecurityConfigurationDefaults' ./api/... ./conf/...passes.hack/mysqld.sh); rungo test ./api/...against it.- Description for the changelog
Enforce a configurable minimum password length on Identity instances that opt in to strict security.
Link EX-1871